rw2sender-fix: moved to programatic approach#212
Open
bwplotka wants to merge 4 commits intofeature/rw2senderfixfrom
Open
rw2sender-fix: moved to programatic approach#212bwplotka wants to merge 4 commits intofeature/rw2senderfixfrom
bwplotka wants to merge 4 commits intofeature/rw2senderfixfrom
Conversation
Signed-off-by: bwplotka <bwplotka@gmail.com>
bwplotka
commented
Feb 20, 2026
| return labels.FormatOpenMetricsFloat(v) | ||
| } | ||
|
|
||
| func samplesTests() []Test { |
Member
Author
There was a problem hiding this comment.
FYI: Moved 1:1 from samples_test
Signed-off-by: bwplotka <bwplotka@gmail.com>
saswatamcode
approved these changes
Feb 20, 2026
Member
saswatamcode
left a comment
saswatamcode
left a comment
There was a problem hiding this comment.
LGTM! This looks super clean!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Progresses #208
See an example use prometheus/prometheus#18121
This rewrites the framework so it can be used programmatically (go imported) and adds a sample test that shows how it's used.
Also:
cc @pipiland2612 @saswatamcode