rw2sender-fix: Redesign test framework as a sendertest package; add process target#211
Merged
bwplotka merged 4 commits intofeature/rw2senderfixfrom Feb 20, 2026
Merged
Conversation
bwplotka
changed the title
bwplotka
force-pushed
the
rw2sender-fix-3
branch
3 times, most recently
from
ba6ab1b to
bb4caa2
Compare
saswatamcode
approved these changes
Feb 18, 2026
Member
saswatamcode
left a comment
saswatamcode
left a comment
There was a problem hiding this comment.
Generally looks good to me, a couple of questions
| if err != nil { | ||
| return err | ||
| } | ||
| fName, err := writeTempFile(string(out), "target-options-*.yaml") |
Member
There was a problem hiding this comment.
Why is the file named this way?
Member
Author
There was a problem hiding this comment.
What else would you expect?
I am considering also stdin. I will try to setup CI job for this in Prometheus before merging
Member
There was a problem hiding this comment.
I got confused with the -* suffix
Member
Author
There was a problem hiding this comment.
Ah - it's a magic pattern for random UUID for temp file. Will comment.
Signed-off-by: bwplotka <bwplotka@gmail.com>
bwplotka
force-pushed
the
rw2sender-fix-3
branch
2 times, most recently
from
3c217b8 to
46eba96
Compare
Signed-off-by: bwplotka <bwplotka@gmail.com>
bwplotka
force-pushed
the
rw2sender-fix-3
branch
from
46eba96 to
decdea6
Compare
Signed-off-by: bwplotka <bwplotka@gmail.com>
bwplotka
force-pushed
the
rw2sender-fix-3
branch
2 times, most recently
from
948fe20 to
2678811
Compare
Signed-off-by: bwplotka <bwplotka@gmail.com>
bwplotka
force-pushed
the
rw2sender-fix-3
branch
from
2678811 to
0e0f72d
Compare
Member
Author
|
Merging this, but I decided to switch a design to be programmatic more (next PR) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #210
This rewrites the framework and adds a sample test that shows how it's used.
Removed old tests in this PR:
Next PRs will delete/convert rest of the old tests cc @pipiland2612