remotewrite/sender: Fixed RW sending compliance tests#207
Closed
remotewrite/sender: Fixed RW sending compliance tests#207
Conversation
Signed-off-by: bwplotka <bwplotka@gmail.com>
Signed-off-by: bwplotka <bwplotka@gmail.com>
Signed-off-by: bwplotka <bwplotka@gmail.com>
5d86fc8 to
667a9b7
Compare
Signed-off-by: bwplotka <bwplotka@gmail.com>
667a9b7 to
2f8dbc8
Compare
Member
Author
|
Talking internally with @pipiland2612 and @saswatamcode on how to split/review/finish this |
Member
Author
|
Moving to a feature branch as agreed #208 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During our LFX mentorship, @pipiland2612 redesigned our compliance sending tests -- in-line with #182. The #194 PR was pending for long time and unfortunately I merged it without careful review to iterate.
The introduced refactor added a lot of good RW2 tests, but had a lot of inconsistencies, false positive, noop and duplicated tests, (e..g exemplars passing, without detecting critical issue). I should have review previous PR carefully and guide @pipiland2612 , but I didn't, so trying to fix it here.
The work was MUCH easier with @pipiland2612 initial PR, I just had to clean up and adjust some tests. I left out some commented code, feel free @pipiland2612 to help and add PR to this PR to iterate 🤗
Changes:
sendertestframework. No exception.prometheus_testfile and ensured RECOMMENDED for those.TODO:
This cleans and fixes up the early test we merged recently