chore (internal): Use go tools in internal/tools#5035
Open
SoloJacobs wants to merge 5 commits intoprometheus:mainfrom
Open
chore (internal): Use go tools in internal/tools#5035SoloJacobs wants to merge 5 commits intoprometheus:mainfrom
internal/tools#5035SoloJacobs wants to merge 5 commits intoprometheus:mainfrom
Conversation
This action has multiple flaws: * It is redundant, since we execute `make lint` in `.github/workflows/ci.yml`. * It ignores `make lint`: If we want to remove our build artefacts from the repository, then we can't run `golangci-lint` without first creating the artefacts. * It contains redundant logic, specific to other projects, and refers to it being synced from https://github.com/prometheus/prometheus (which is false. `prometheus` does not even use this action anymore). Signed-off-by: Solomon Jacobs <solomonjacobs@protonmail.com>
This commit simply runs `golangci-lint run --fix`. Signed-off-by: Solomon Jacobs <solomonjacobs@protonmail.com>
The usage of this tool was removed in this commit: a3a156d Signed-off-by: Solomon Jacobs <solomonjacobs@protonmail.com>
We keep `internal/tools`. This prevents those building from source from downloading these dependencies and reduces overall dependency conflicts. The only downside is that build dependencies could in theory affect the security of alertmanager, albeit this is overly pedantic. The actual vulnerable code would be checked into our repo anyway. Related-to: prometheus#4961 Signed-off-by: Solomon Jacobs <solomonjacobs@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See commit messages for detailed explanation. Stacks on top of #5033
Pull Request Checklist
Which user-facing changes does this PR introduce?