Skip to content

Comments

fix: force_implicit_tls config field name in docs#5030

Merged
Spaceman1701 merged 1 commit intoprometheus:mainfrom
Spaceman1701:fix/email-tls-docs
Feb 22, 2026
Merged

fix: force_implicit_tls config field name in docs#5030
Spaceman1701 merged 1 commit intoprometheus:mainfrom
Spaceman1701:fix/email-tls-docs

Conversation

@Spaceman1701
Copy link
Contributor

@Spaceman1701 Spaceman1701 commented Feb 21, 2026

Pull Request Checklist

Please check all the applicable boxes.

Which user-facing changes does this PR introduce?

[BUGFIX] fix the name of `force_implicit_tls` in the configuration docs and add global `smtp_force_implicit_tls` to the docs. Both fields already exist, but the documentation was incorrect.

#4818 added force_implicit_tls to the email receiver, but accidentally documented the field as implicit_tls. The documentation in that change also forgot to mention the smpt_force_implicit_tls filed in the the global section. This PR just modifies the docs to match the existing behavior.

See

ForceImplicitTLS *bool `yaml:"force_implicit_tls,omitempty" json:"force_implicit_tls,omitempty"`
and
SMTPForceImplicitTLS *bool `yaml:"smtp_force_implicit_tls,omitempty" json:"smtp_force_implicit_tls,omitempty"`

Thanks @nutmos for discovering this!

Signed-off-by: Ethan Hunter <fc.spaceman@gmail.com>
Copy link
Contributor

@SoloJacobs SoloJacobs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, a classic 😃

@Spaceman1701
Copy link
Contributor Author

I think one review is enough to go ahead and merge. Doing that now :)

@Spaceman1701 Spaceman1701 merged commit 2e693f2 into prometheus:main Feb 22, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants