chore (workflows): Don't use redundant action#5029
Open
SoloJacobs wants to merge 1 commit intoprometheus:mainfrom
Open
chore (workflows): Don't use redundant action#5029SoloJacobs wants to merge 1 commit intoprometheus:mainfrom
SoloJacobs wants to merge 1 commit intoprometheus:mainfrom
Conversation
SoloJacobs
force-pushed
the
remove-golangci
branch
from
62f7185 to
15630b3
Compare
This action has multiple flaws: * It is redundant, since we execute `make lint` in `.github/workflows/ci.yml`. * It ignores `make lint`: If we want to remove our build artefacts from the repository, then we can't run `golangci-lint` without first creating the artefacts. * It contains redundant logic, specific to other projects, and refers to it being synced from https://github.com/prometheus/prometheus (which is false. `prometheus` does not even use this action anymore). Signed-off-by: Solomon Jacobs <solomonjacobs@protonmail.com>
SoloJacobs
force-pushed
the
remove-golangci
branch
from
15630b3 to
16421eb
Compare
SoloJacobs
requested review from
Spaceman1701,
SuperQ,
TheMeier,
siavashs and
ultrotter
SuperQ
approved these changes
Feb 22, 2026
siavashs
approved these changes
Feb 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This action has multiple flaws:
make lintin.github/workflows/ci.yml.make lint: If we want to remove our build artefacts from the repository, then we can't rungolangci-lintwithout first creating the artefacts.prometheusdoes not even use this action anymore).Pull Request Checklist
Please check all the applicable boxes.
benchstatto compare benchmarksWhich user-facing changes does this PR introduce?