add client_addr to metric pg_stat_activity_max_tx_duration#986
add client_addr to metric pg_stat_activity_max_tx_duration#986betanummeric wants to merge 1 commit intoprometheus-community:masterfrom
Conversation
SuperQ
left a comment
There was a problem hiding this comment.
Hmm, this could impact cardinality very badly as things scale up. I'm not sure this would be acceptable for most users.
|
@SuperQ I don't think most users have so much more client hosts than postgres-users to make the |
|
An opt-in flag would be fine. The only issue is that this collector setup hasn't been moved to our new collector package, so it's possibly slightly difficult to implement here. |
|
I don't know that we have had a good example of customizing a collector that has been ported to the collector package either. I remember another request noting that the constructors for collectors don't have an obvious pattern for customization. @SuperQ Do we have a good example from another exporter for customizing collectors? |
implements #985