Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Kubeflow notebook runtime image to include GitHub’s CLI tooling (gh) plus the gh-copilot-review extension, and documents the new preinstalled tools for users of the image.
Changes:
- Install
github-cli(gh) in the Kubeflow runtime image. - Preinstall
gh-copilot-reviewfor thejovyanuser and pin it to a specific commit for reproducibility. - Document the preinstalled tooling and add an Unreleased changelog entry.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| docker/kubeflow/Dockerfile | Installs gh and bakes in a pinned gh-copilot-review extension in the jovyan home template. |
| docker/kubeflow/README.md | Documents that gh and gh-copilot-review are preinstalled and how they’re pinned. |
| CHANGELOG.md | Adds an Unreleased “Added” entry for the Kubeflow image tooling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
docker/kubeflow/Dockerfile
Outdated
| RUN printf 'git_protocol: https\nprompt: disabled\nversion: "1"\n' > /home/jovyan/.config/gh/config.yml && \ | ||
| printf 'github.com:\n user: jovyan\n oauth_token: ""\n git_protocol: https\n' > /home/jovyan/.config/gh/hosts.yml |
docker/kubeflow/Dockerfile
Outdated
| # The extension has no tags/releases, so pin to an audited commit for reproducibility. | ||
| ARG GH_COPILOT_REVIEW_REF=1dfe6cd4abf66f8d45cbc0b3de26cf202fd27910 | ||
| RUN git clone https://github.com/ChrisCarini/gh-copilot-review /home/jovyan/.local/share/gh/extensions/gh-copilot-review && \ | ||
| git -C /home/jovyan/.local/share/gh/extensions/gh-copilot-review checkout "${GH_COPILOT_REVIEW_REF}" |
There was a problem hiding this comment.
Pull request overview
This PR updates the Kubeflow notebook runtime image to include GitHub CLI tooling needed by the repo’s agent workflow, and documents the addition for users.
Changes:
- Install GitHub CLI (
gh) in the Kubeflow runtime image. - Preinstall the
gh-copilot-reviewextension for thejovyanuser, pinned to a specific commit for reproducible builds. - Document the preinstalled tooling in Kubeflow image docs and add an Unreleased changelog entry.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
docker/kubeflow/Dockerfile |
Adds github-cli, provisions gh config dirs, and installs the gh-copilot-review extension pinned to a commit. |
docker/kubeflow/README.md |
Documents that gh and gh-copilot-review are available in the Kubeflow image. |
CHANGELOG.md |
Adds an Unreleased “Added” entry for the Kubeflow image tooling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
docker/kubeflow/Dockerfile
Outdated
| /tmp_home \ | ||
| /run | ||
|
|
||
| RUN printf 'git_protocol: https\nprompt: disabled\nversion: "1"\n' > /home/jovyan/.config/gh/config.yml && \ |
There was a problem hiding this comment.
Pull request overview
This PR updates the Kubeflow notebook runtime image to include GitHub’s CLI tooling required by the repo’s agent workflow, and documents the new preinstalled tools for users.
Changes:
- Install GitHub CLI (
gh) in the Kubeflow runtime image. - Preinstall the
gh-copilot-reviewextension for thejovyanuser, pinned to a specific commit for reproducibility. - Document the tooling in the Kubeflow image README and add an Unreleased changelog entry.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
docker/kubeflow/Dockerfile |
Adds github-cli and installs a pinned gh-copilot-review extension into the jovyan home template. |
docker/kubeflow/README.md |
Documents gh and gh-copilot-review as preinstalled developer tooling. |
CHANGELOG.md |
Adds an Unreleased entry for the new Kubeflow image tooling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| RUN printf 'git_protocol: https\nversion: "1"\n' > /home/jovyan/.config/gh/config.yml && \ | ||
| printf 'github.com:\n git_protocol: https\n' > /home/jovyan/.config/gh/hosts.yml | ||
|
|
There was a problem hiding this comment.
Pull request overview
This PR updates the Kubeflow notebook runtime image to include GitHub’s CLI tooling needed by the repo’s agent workflow, and documents the new preinstalled tools for users of the image.
Changes:
- Install GitHub CLI (
gh) in the Kubeflow runtime image. - Preinstall
gh-copilot-reviewfor the runtime user (jovyan) pinned to a specific commit viaGH_COPILOT_REVIEW_REF. - Document the preinstalled tools in the Kubeflow image README and add an Unreleased changelog entry.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
docker/kubeflow/Dockerfile |
Adds github-cli, creates gh config directories, and installs the pinned gh-copilot-review extension into jovyan’s home. |
docker/kubeflow/README.md |
Documents that gh and gh-copilot-review are preinstalled and notes the pinning mechanism. |
CHANGELOG.md |
Adds an Unreleased “Added” entry describing the Kubeflow image tooling addition. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Summary
gh) in the Kubeflow runtime imagegh-copilot-reviewfor thejovyanruntime user and pin it to a commit for reproducible buildsValidation
Closes #194