React redux task#5
Open
prokhorovd wants to merge 47 commits into
Open
Conversation
fix: provide case for empty search value fix: fix total number of news calculation fix: searchValue and value of search field are separated fix: disable -next- button on empty page refactor: few cosmetic details refactor: remove unnecessary types
awpogodin
reviewed
Nov 7, 2021
| let value = ''; | ||
| if (typeof data[1] === 'string') { | ||
| value = data[1].toString(); | ||
| } else if (typeof data[1] === 'object' && data[1] !== null) { |
Collaborator
There was a problem hiding this comment.
without types, it looks very complicated and confusing. Consider refactoring
…, use react-router api, etc
awpogodin
reviewed
Nov 11, 2021
awpogodin
reviewed
Nov 11, 2021
| data: ArticleInfo | ||
| } | ||
|
|
||
| function objFlatter(obj: {[index: string]:any}, prefix = ''): object { |
awpogodin
reviewed
Nov 11, 2021
| pageSize: 100, | ||
| sortBy: 'publishedAt', | ||
| id: '', | ||
| searchValue: query.get('searchValue'), |
Collaborator
There was a problem hiding this comment.
you can create const with params to avoid magic strings) but up to you
const queryParams = {
searchValue: 'searchValue',
sortBy: 'sortBy',
...
};
...
const linkParams: Args = {
[queryParams.searchValue]: query.get(queryParams.searchValue),
...
};
awpogodin
reviewed
Nov 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.