Open
Conversation
This metric enables us to easily consume Lieutenant cluster dynamic facts through Prometheus queries (e.g. for central dashboards). We currently don't filter out any dynamic facts, and accept that the metric may have sizeable label values. Generally speaking, Prometheus should be able to handle bigger label values gracefully, but if the larger label values (currently primarily `status.facts.kubernetesVersion`) turn out to be an issue, we can always drop them with a scrape relabel config (in the `ServiceMonitor` for each Lieutenant instance).
simu
commented
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This metric enables us to easily consume Lieutenant cluster dynamic facts through Prometheus queries (e.g. for central dashboards).
We currently don't filter out any dynamic facts, and accept that the metric may have sizeable label values.
Generally speaking, Prometheus should be able to handle bigger label values gracefully, but if the larger label values (currently primarily
status.facts.kubernetesVersion) turn out to be an issue, we can always drop them with a scrape relabel config (in theServiceMonitorfor each Lieutenant instance).Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog