Skip to content

Fix namespace labels rendering #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DebakelOrakel merged 1 commit into from
May 7, 2026
Merged

Fix namespace labels rendering #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion component/main.jsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ local netpols = kube.NetworkPolicy('allow-from-other-namespaces') {
metadata+: {
labels+: {
'app.kubernetes.io/managed-by': 'commodore',
'app.kubernetes.io/name': params.namespace,
'app.kubernetes.io/name': params.namespace.name,
[if params.global.zoneAwareReplication.enabled then 'rollout-operator.syn.tools/allow']: '',
},
} + com.makeMergeable(params.namespace.metadata),
Expand Down
5 changes: 1 addition & 4 deletions tests/golden/defaults/defaults/defaults/00_namespace.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@ metadata:
annotations: {}
labels:
app.kubernetes.io/managed-by: commodore
app.kubernetes.io/name:
create: true
metadata: {}
name: defaults
app.kubernetes.io/name: defaults
name: defaults
name: defaults
5 changes: 1 addition & 4 deletions tests/golden/extra-config/extra-config/extra-config/00_namespace.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,7 @@ metadata:
annotations: {}
labels:
app.kubernetes.io/managed-by: commodore
app.kubernetes.io/name:
create: true
metadata: {}
name: extra-config
app.kubernetes.io/name: extra-config
name: extra-config
rollout-operator.syn.tools/allow: ''
name: extra-config
5 changes: 1 addition & 4 deletions tests/golden/legacy/legacy/legacy/00_namespace.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@ metadata:
annotations: {}
labels:
app.kubernetes.io/managed-by: commodore
app.kubernetes.io/name:
create: true
metadata: {}
name: legacy
app.kubernetes.io/name: legacy
name: legacy
name: legacy
5 changes: 1 addition & 4 deletions tests/golden/openshift/openshift/openshift/00_namespace.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,7 @@ metadata:
annotations: {}
labels:
app.kubernetes.io/managed-by: commodore
app.kubernetes.io/name:
create: true
metadata: {}
name: openshift
app.kubernetes.io/name: openshift
name: openshift
rollout-operator.syn.tools/allow: ''
name: openshift
5 changes: 1 addition & 4 deletions tests/golden/preset-large/preset-large/preset-large/00_namespace.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@ metadata:
annotations: {}
labels:
app.kubernetes.io/managed-by: commodore
app.kubernetes.io/name:
create: true
metadata: {}
name: preset-large
app.kubernetes.io/name: preset-large
name: preset-large
name: preset-large
5 changes: 1 addition & 4 deletions tests/golden/preset-small/preset-small/preset-small/00_namespace.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@ metadata:
annotations: {}
labels:
app.kubernetes.io/managed-by: commodore
app.kubernetes.io/name:
create: true
metadata: {}
name: preset-small
app.kubernetes.io/name: preset-small
name: preset-small
name: preset-small
Loading