Skip to content

feat: add support for ssh_endpoint#140

Merged
simu merged 6 commits intoprojectsyn:masterfrom
containeroo:master
May 6, 2026
Merged

feat: add support for ssh_endpoint#140
simu merged 6 commits intoprojectsyn:masterfrom
containeroo:master

Conversation

@rxbn
Copy link
Copy Markdown
Contributor

@rxbn rxbn commented Feb 5, 2026

Checklist

  • The PR has a meaningful title. It will be used to auto-generate the
    changelog.
    The PR has a meaningful description that sums up the change. It will be
    linked in the changelog.
  • PR contains a single logical change (to build a better changelog).
  • Update the documentation.
  • Categorize the PR by adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.
  • Link this PR to related issues or PRs.

Copy link
Copy Markdown
Member

@simu simu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rxbn, I just saw this PR (shortly after creating a new release). Overall, the change looks good, I've left some comments inline.

If you rebase this onto the latest master branch, we should be able to release this.

Comment thread component/app.jsonnet
Comment thread component/githosts.jsonnet Outdated
Comment thread docs/modules/ROOT/pages/how-tos/setup-githost.adoc Outdated
Comment thread docs/modules/ROOT/pages/how-tos/setup-githost.adoc
Comment thread docs/modules/ROOT/pages/how-tos/vcluster.adoc Outdated
@rxbn
Copy link
Copy Markdown
Contributor Author

rxbn commented Apr 30, 2026

Hi @simu

Thanks for your review. I have applied your suggestions.

Best,
Robin

@rxbn
Copy link
Copy Markdown
Contributor Author

rxbn commented Apr 30, 2026

I have just noticed that your change in regards to [if std.objectHas(gh, 'ssh_endpoint') then 'sshEndpoint']: std.get(gh, ssh_endpoint) didn't work. I am looking for a solution.

Edit: Should work now

@rxbn
Copy link
Copy Markdown
Contributor Author

rxbn commented Apr 30, 2026

Could you also have a look at projectsyn/commodore-compile-pipelines#28? A review would be much appreciated!

@rxbn rxbn requested a review from simu May 6, 2026 08:32
@simu simu added enhancement New feature or request bump:minor labels May 6, 2026
@simu simu removed the bump:minor label May 6, 2026
@simu simu merged commit f6e6437 into projectsyn:master May 6, 2026
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants