Open
Conversation
| </head> | ||
| <body> | ||
| <div class="container"> | ||
|
|
Comment on lines
+21
to
+23
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
no need for empty spaces, affects the code flow
| // create eventlistener and variable | ||
|
|
||
| document.getElementById('button-search').addEventListener('click', function() { | ||
| let townName = document.getElementById('current-town').value; |
There was a problem hiding this comment.
why let ? this is should be a const, check ES6 best practices
| // create eventlistener and variable | ||
|
|
||
| document.getElementById('button-search').addEventListener('click', function() { | ||
| let townName = document.getElementById('current-town').value; |
There was a problem hiding this comment.
here is where you are missing the empty input validation. Very important to consider, or your app will crash
|
|
||
| document.getElementById('button-search').addEventListener('click', function() { | ||
| let townName = document.getElementById('current-town').value; | ||
|
|
Comment on lines
+14
to
+22
| const apiKey = '63168e96197ab571649bdefbef398926'; | ||
| const currentWeatherApiUrl = `https://api.openweathermap.org/data/2.5/weather?q=${townName}&units=imperial&appid=${apiKey}`; | ||
| //create fetch to grab data, add error check as well | ||
| fetch(currentWeatherApiUrl) | ||
| .then(response => response.json()) | ||
| .then(data => { | ||
| showPresentWeather(data); | ||
| predictClimate(townName, apiKey) | ||
| }) |
| //create fetch to grab data, add error check as well | ||
| fetch(currentWeatherApiUrl) | ||
| .then(response => response.json()) | ||
| .then(data => { |
There was a problem hiding this comment.
be more descriptive, data tells not much,
Suggested change
| .then(data => { | |
| .then(weatherData => { |
| } | ||
| //create fxn fivedayweather | ||
|
|
||
| function fiveDayWeather(data) { |
|
|
||
| //find last town searched and save | ||
| document.getElementById('button-search').addEventListener('click', function() { | ||
| let townName = document.getElementById('current-town').value; |
|
|
||
| }); | ||
| window.onload = function() { | ||
| let previousTown = localStorage.getItem('previousTown'); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.