Merged
Conversation
Co-authored-by: Egor <ezzer17@users.noreply.github.com> Signed-off-by: Dwi Siswanto <git@dw1.io>
Add `(*SizedPool[T]).Discard` method that releases the semaphore slot without returning the item to the underlying [sync.Pool]. This enables callers to properly release resources when intentionally discarding items (e.g., oversized buffers) instead of returning them to the pool. Also, refactor `(*SizedPool[T]).Put()` to use `(*SizedPool[T]).Discard()` internally. Signed-off-by: Dwi Siswanto <git@dw1.io>
When `putBuffer()` discarded buffers (either oversized or when the large buffer channel was full), the sizedpool semaphore slot acquired by `getBuffer()` was never released. This caused semaphore exhaustion and eventual deadlock under sustained load with large response bodies. Call `bufPool.Discard()` in both discard paths to properly release the semaphore slot. Fixes #714. Signed-off-by: Dwi Siswanto <git@dw1.io>
Mzack9999
approved these changes
Dec 19, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Proof
patch:
main: