Skip to content

feat: add DisableHTTPFallback to respect explicit HTTP/1.1 configuration #529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hetbhatt2807 wants to merge 1 commit into from
Closed

feat: add DisableHTTPFallback to respect explicit HTTP/1.1 configuration #529

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ type Client struct {
Backoff Backoff

options Options
DisableHTTPFallback bool
Copy link
Copy Markdown
Member

@Mzack9999 Mzack9999 Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code should be aligned to the left (if you use vscode or cursor it should automatically fmt on file save)

}

// Options contains configuration options for the client
Expand Down
11 changes: 8 additions & 3 deletions do.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,14 @@ func (c *Client) Do(req *Request) (*http.Response, error) {
checkOK, checkErr := c.CheckRetry(req.Context(), resp, err)

// if err is equal to missing minor protocol version retry with http/2
if err != nil && stringsutil.ContainsAny(err.Error(), "net/http: HTTP/1.x transport connection broken: malformed HTTP version \"HTTP/2\"", "net/http: HTTP/1.x transport connection broken: malformed HTTP response") {
resp, err = c.HTTPClient2.Do(req.Request)
checkOK, checkErr = c.CheckRetry(req.Context(), resp, err)
if !c.DisableHTTPFallback &&
Copy link
Copy Markdown
Member

@Mzack9999 Mzack9999 Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we can control this at package level with something like:

var ENABLE_HTTP2 = true

with default value to true, so that users can disable it via code. What do you think?

err != nil &&
stringsutil.ContainsAny(err.Error(),
"net/http: HTTP/1.x transport connection broken: malformed HTTP version \"HTTP/2\"",
"net/http: HTTP/1.x transport connection broken: malformed HTTP response") {

resp, err = c.HTTPClient2.Do(req.Request)
checkOK, checkErr = c.CheckRetry(req.Context(), resp, err)
}

if err != nil {
Expand Down
Loading