Skip to content

feat: add DisableHTTP2Fallback option to prevent automatic HTTP/2 fallback #526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MrLawrenceKwan wants to merge 1 commit into from
Closed

feat: add DisableHTTP2Fallback option to prevent automatic HTTP/2 fallback #526

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,10 @@ type Options struct {
//
// If less than or equal to zero, defaults to 1024.
TLSSessionCacheSize int
// DisableHTTP2Fallback disables automatic fallback to HTTP/2 client on malformed HTTP/2 errors.
// When enabled, HTTP/1.x transport errors are handled according to the retry policy
// instead of automatically switching to HTTP/2.
DisableHTTP2Fallback bool
}

// DefaultOptionsSpraying contains the default options for host spraying
Expand Down
3 changes: 2 additions & 1 deletion do.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,8 @@ func (c *Client) Do(req *Request) (*http.Response, error) {
checkOK, checkErr := c.CheckRetry(req.Context(), resp, err)

// if err is equal to missing minor protocol version retry with http/2
if err != nil && stringsutil.ContainsAny(err.Error(), "net/http: HTTP/1.x transport connection broken: malformed HTTP version \"HTTP/2\"", "net/http: HTTP/1.x transport connection broken: malformed HTTP response") {
// unless HTTP/2 fallback is explicitly disabled
if !c.options.DisableHTTP2Fallback && err != nil && stringsutil.ContainsAny(err.Error(), "net/http: HTTP/1.x transport connection broken: malformed HTTP version \"HTTP/2\"", "net/http: HTTP/1.x transport connection broken: malformed HTTP response") {
resp, err = c.HTTPClient2.Do(req.Request)
checkOK, checkErr = c.CheckRetry(req.Context(), resp, err)
}
Expand Down