Skip to content

feat: add DisableHTTP2Fallback option #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jpirstin wants to merge 2 commits into from
Closed

feat: add DisableHTTP2Fallback option #524

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed815bc
feat: add DisableHTTP2Fallback option to prevent unwanted HTTP/2 fall…
jpirstin Feb 16, 2026
57562a1
ci: trigger CI checks
jpirstin Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,10 @@ type Options struct {
Backoff Backoff
// NoAdjustTimeout disables automatic adjustment of HTTP request timeout
NoAdjustTimeout bool
// DisableHTTP2Fallback disables automatic fallback to HTTP/2 when HTTP/1.x
// transport encounters malformed HTTP version errors. This should be set
// when the caller explicitly wants HTTP/1.1 only.
DisableHTTP2Fallback bool
// Custom http client
HttpClient *http.Client
// WrapTransport wraps the underlying [http.RoundTripper].
Expand Down
2 changes: 1 addition & 1 deletion do.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ func (c *Client) Do(req *Request) (*http.Response, error) {
checkOK, checkErr := c.CheckRetry(req.Context(), resp, err)

// if err is equal to missing minor protocol version retry with http/2
if err != nil && stringsutil.ContainsAny(err.Error(), "net/http: HTTP/1.x transport connection broken: malformed HTTP version \"HTTP/2\"", "net/http: HTTP/1.x transport connection broken: malformed HTTP response") {
if !c.options.DisableHTTP2Fallback && err != nil && stringsutil.ContainsAny(err.Error(), "net/http: HTTP/1.x transport connection broken: malformed HTTP version \"HTTP/2\"", "net/http: HTTP/1.x transport connection broken: malformed HTTP response") {
resp, err = c.HTTPClient2.Do(req.Request)
checkOK, checkErr = c.CheckRetry(req.Context(), resp, err)
}
Expand Down