Solve race condition that causes the solution to not respect CIDN and CIDL as described in Issue 229#230
Open
pwnpanda wants to merge 1 commit intoprojectdiscovery:mainfrom
Open
Solve race condition that causes the solution to not respect CIDN and CIDL as described in Issue 229#230pwnpanda wants to merge 1 commit intoprojectdiscovery:mainfrom
pwnpanda wants to merge 1 commit intoprojectdiscovery:mainfrom
Conversation
…ondition that makes cidl and cidn not register when using the UI
|
@pwnpanda is attempting to deploy a commit to the ProjectDiscovery Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change from getStoredData to flushStoredData in order to avoid race condition that makes cidl and cidn not register correctly when using the UI.
It has been tested locally and resolves the issue, by using flushStoredData instead of getStoredData.
This pull request resolves this issue:
Issue 229
PS: I tried to find any tests that need to be ran, but did not find anything except the "build for production"-commands. I found an issue with problematic JSON response from server to the UI, but I cannot understand that it is related to this change. Open to input on this!