Fix issue where web UI stops showing interactions#210
Open
pasiorovuo wants to merge 1 commit intoprojectdiscovery:mainfrom
Open
Fix issue where web UI stops showing interactions#210pasiorovuo wants to merge 1 commit intoprojectdiscovery:mainfrom
pasiorovuo wants to merge 1 commit intoprojectdiscovery:mainfrom
Conversation
|
@pasiorovuo is attempting to deploy a commit to the ProjectDiscovery Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the locally stored key expires (but is still present in local storage) the interface stops displaying new interactions because decryption fails. The interface refreshes and there will be absolutely no indicator of a lost interaction. With this change the key included in the payload is used. The behaviour seems to be aligned with what the command line client does. Additionally, we log errors instead of swallowing them silently.
The issue was discussed shortly here: https://discord.com/channels/695645237418131507/1438554105772507166