[refactor] Remove the prometheus dependency on pubsub#784
Merged
Conversation
sknat
reviewed
Jan 7, 2026
Collaborator
sknat
left a comment
There was a problem hiding this comment.
I think we can cherry pick this part of the refactoring safely on master and merge it before waiting for the rest of the other patches to go in
Signed-off-by: Aritra Basu <aritrbas@cisco.com>
2f12f72 to
d77c172
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
What Changed
Before:
common.PodAddedandcommon.PodDeletedevents on a channel.After:
NewFelixServer().ServePrometheus()is started as a goroutine withinServeFelix()using the tomb lifecycle manager.s.prometheusServer.OnPodAdded()ands.prometheusServer.OnPodDeleted()are now made for pod event handling.OnPodAdded()andOnPodDeleted()are added inprometheus.gothat directly handle pod lifecycle events.Event Flow:
PodAdded/PodDeletedevent to Felix's event channel.handleFelixServerEvents()processes the event.workloadAdded()/WorkloadRemoved()to update policy state.s.prometheusServer.OnPodAdded()/s.prometheusServer.OnPodDeleted()to notify Prometheus.