Run e2e tests with felix programming cluster routes#11293
Merged
mazdakn merged 15 commits intoprojectcalico:masterfrom Mar 5, 2026
Merged
Run e2e tests with felix programming cluster routes#11293mazdakn merged 15 commits intoprojectcalico:masterfrom
mazdakn merged 15 commits intoprojectcalico:masterfrom
Conversation
marvin-tigera
added
release-note-required
mazdakn
added
docs-not-required
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for running e2e conformance tests with BGP disabled in Calico. The changes introduce a configurable BGP_CONFIG environment variable that allows the test infrastructure to deploy Calico with BGP disabled and adjust Felix configuration accordingly.
Key changes:
- Add a new Helm values file for BGP-disabled configurations
- Modify deployment scripts to conditionally apply BGP settings and Felix configuration
- Add a new CI job to run e2e tests with BGP disabled
- Update operator branch reference to
felix-routing
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| node/tests/k8st/infra/values_no_bgp.yaml | New Helm values file that disables BGP and sets dual-stack IP pools |
| node/tests/k8st/deploy_resources_on_kind_cluster.sh | Updated to conditionally use BGP-disabled values and patch Felix configuration |
| node/Makefile | Passes BGP_CONFIG environment variable to deployment script |
| Makefile | Defines BGP_CONFIG variable and passes it to e2e test execution |
| .semaphore/semaphore.yml | Adds new CI job for e2e tests with BGP disabled |
| metadata.mk | Changes operator branch reference from master to felix-routing |
Contributor
|
This PR is stale because it has been open for 60 days with no activity. |
caseydavenport
approved these changes
Mar 5, 2026
Member
caseydavenport
left a comment
caseydavenport
left a comment
There was a problem hiding this comment.
I think the copilot suggestions seem correct, but otherwise this LGTM. I'm assuming we don't have a way to configure this in the operator API, do we need / want one?
Another thought is that we create a default FelixConfiguration from within the product, but we don't for BGPConfiguration... should we?
mazdakn
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Run e2e tests with Felix programming cluster routes.
Related issues/PRs
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.