Skip to content

πŸ›‘οΈ Sentinel: [HIGH] Fix XSS in event preview formatting#867

Open
kevinaboos wants to merge 1 commit into
mainfrom
sentinel-xss-event-preview-7387762487924466894
Open

πŸ›‘οΈ Sentinel: [HIGH] Fix XSS in event preview formatting#867
kevinaboos wants to merge 1 commit into
mainfrom
sentinel-xss-event-preview-7387762487924466894

Conversation

@kevinaboos
Copy link
Copy Markdown
Member

🚨 Severity: HIGH
πŸ’‘ Vulnerability: Cross-Site Scripting (XSS) / HTML injection via unsanitized Matrix event previews. User-controlled text such as custom event types, custom guest access rules, custom history visibility, custom join rules, aliases, and canonical aliases were directly embedded into formatted strings in src/event_preview.rs and rendered as HTML without escaping.
🎯 Impact: An attacker could inject malicious HTML or script tags into the application by setting crafted custom rules, aliases, or sending messages with malicious event types. When a user views the timeline, the unsanitized preview could execute arbitrary code or corrupt the UI, potentially compromising their session.
πŸ”§ Fix: Updated text_preview_of_other_state and text_preview_of_other_message_like to properly escape the relevant string values using htmlize::escape_text whenever format_as_html is true. text_preview_of_other_message_like was also updated to accept the format_as_html parameter and all its call sites were adjusted accordingly.
βœ… Verification: Ran cargo check, cargo clippy, and cargo test --lib successfully. Reviewed the code to ensure htmlize::escape_text is correctly applied to the user-controlled strings and that lifetimes are managed correctly (e.g. using Cow::Borrowed when escaping is not needed and allocating where necessary).


PR created automatically by Jules for task 7387762487924466894 started by @kevinaboos

Sanitized user-controlled fields within `AnyOtherStateEventContentChange` and `OtherMessageLike` (like aliases, custom rules, and event types) in `src/event_preview.rs` when generating HTML previews.

Co-authored-by: kevinaboos <1139460+kevinaboos@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant