Fix gh-release and jboss-parent overrides#34
Merged
rnc merged 4 commits intoproject-ncl:mainfrom Apr 29, 2026
Merged
Conversation
This was referenced Apr 29, 2026
| # releaseProfile: Use the central profile not jboss-release | ||
| # signTag: Reset back to maven-release-plugin default | ||
| # tagNameFormat: Reset to maven-release-plugin default | ||
| default: '-Dcentral.serverId=central-publisher -Dcentral.autoPublish=false -DreleaseProfile=central-release -DsignTag=false -DtagNameFormat=@{project.artifactId}-@{project.version}' |
Contributor
There was a problem hiding this comment.
Would the central-release profile break the older jboss-parent versions?
And the tag name format will deviate from what we currently use which is just project.version I believe.
Contributor
Author
There was a problem hiding this comment.
I think if releaseProfile references a profile that does not exist then Maven will log a warning, ignore it and continue.
Contributor
Author
There was a problem hiding this comment.
I've removed the tagNameFormat override and documented instead how the caller could override it (for those few project-ncl/* repositories that use the default).
thescouser89
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reason to have a separate
jboss_parent_overrideis so that if someone overrides the mvn command line (e.g. to add profiles) then they don't have to remember all of the necessary flags for jboss-parent.