Prepare to publish puzzlefs to crates.io #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevented `cargo package` to correctly include all the files, see https://users.rust-lang.org/t/cargo-package-doesnt-include-entire-source-code/99756 Signed-off-by: Ariel Miculas <amiculas@cisco.com>
Signed-off-by: Ariel Miculas <amiculas@cisco.com>
Run `cargo update`. Signed-off-by: Ariel Miculas <amiculas@cisco.com>
All dependencies must be hosted on crates.io, otherwise we cannot publish the package. For now, version 0.4.1 of daemonize is good enough. We may want to publish a fork of daemonize to crates.io in the future to avoid getting stuck with an old dependency. Note: since version 0.5.0, exit_action was removed from daemonize and we rely on it for the pipe notification mechanism. Signed-off-by: Ariel Miculas <amiculas@cisco.com>
hallyn
approved these changes
Sep 12, 2023
Contributor
|
You said, "Note: since version 0.5.0, exit_action was removed from daemonize and we Have you opened, or should you open, an issue explaining why we need that? Or is it just a matter of "we could do it another way but haven't had the time"? |
Collaborator
Author
|
I did open an issue for another feature I've wanted (the issues tab is not longer public) and I've opened this PR last year but got no response since. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #98