Skip to content

hi PR #724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ChristianZaccaria merged 1 commit into from
Oct 23, 2024
Merged

hi PR #724

ChristianZaccaria merged 1 commit into from
Oct 23, 2024

Conversation

@ChristianZaccaria
Copy link
Contributor

@ChristianZaccaria ChristianZaccaria commented Oct 23, 2024

Issue link

What changes have been made

Verification steps

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@ChristianZaccaria ChristianZaccaria added dependabot test-guided-notebooks Run PR check to verify Guided notebooks e2e and removed test-guided-notebooks Run PR check to verify Guided notebooks labels Oct 23, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 23, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 23, 2024
@ChristianZaccaria ChristianZaccaria added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Oct 23, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ChristianZaccaria ChristianZaccaria added this pull request to the merge queue Oct 23, 2024
Merged via the queue into project-codeflare:test-odh-notebooks-sync with commit ddf4b17 Oct 23, 2024
12 checks passed
@ChristianZaccaria ChristianZaccaria mentioned this pull request Oct 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@franciscojavierarceo franciscojavierarceo Awaiting requested review from franciscojavierarceo

@Ygnas Ygnas Awaiting requested review from Ygnas

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ChristianZaccaria @openshift-merge-robot