[Silabs] Cleanup the namespace hierarchy for the Multi OTA files#42865
Merged
mergify[bot] merged 3 commits intoproject-chip:masterfrom Jan 29, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly refactors the Multi-OTA code by moving several classes into the chip::DeviceLayer::Silabs::MultiOTA namespace, which improves code organization. The changes are consistent across all modified files. I've also noticed and appreciate the improvements to enum class definitions by specifying their underlying types. I have one minor suggestion to remove a redundant using directive for better code clarity.
|
PR #42865: Size comparison from bd1cc4d to 9c2baf4 Full report (32 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
|
PR #42865: Size comparison from bd1cc4d to 31ee598 Full report (5 builds for cc32xx, realtek, stm32)
|
|
PR #42865: Size comparison from bd1cc4d to 8b63c2b Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
jmartinez-silabs
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cleanup the namespace hiearchy of all the Multi-OTA code which belonged directly in the chip namespace
Moved OTAFactoryDataProcessor, FactoryTags, OTAFirmwareProcessor, OTACustomProcessor, and OTAWiFiFirmwareProcessor from chip:: into chip::DeviceLayer::Silabs::MultiOTA
Related issues
NA
Testing
Tested the build with the multi-ota on brd4338a and brd4187c
Readability checklist
The checklist below will help the reviewer finish PR review in time and keep the
code readable:
descriptive
“When in Rome…”
rule (coding style)
See: Pull Request Guidelines