esp32: Add Ethernet support for ESP32-P4#42862
esp32: Add Ethernet support for ESP32-P4#42862mergify[bot] merged 10 commits intoproject-chip:masterfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds Ethernet support for the ESP32-P4 target. It includes a new sdkconfig for the all-clusters-app example, updates Kconfig to define the GPIO range for ESP32-P4, and bumps the version of the esp_hosted dependency. The changes also improve error handling in the Ethernet initialization path.
The changes are well-structured and seem correct for adding support for the new hardware. I have one minor suggestion in NetworkCommissioningDriver_Ethernet.cpp to maintain consistency with the project's coding style for preprocessor directives.
There was a problem hiding this comment.
Pull request overview
Adds an ESP32-P4 Ethernet-focused sdkconfig and small platform tweaks to support running Matter-over-Ethernet on ESP32-P4 boards.
Changes:
- Add
sdkconfig.eth.esp32p4for all-clusters-app to run with Ethernet on ESP32-P4. - Update ESP32 Ethernet driver conditional compilation and ConnectivityManager Ethernet init call.
- Adjust ESP32-P4 GPIO range defaults and pin
esp_hostedcomponent version for ESP32-P4 builds.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/platform/ESP32/NetworkCommissioningDriver_Ethernet.cpp | Adjusts OpenETH conditional compilation in Ethernet driver init. |
| src/platform/ESP32/ConnectivityManagerImpl.cpp | Changes Ethernet init call to use ReturnErrorOnFailure. |
| examples/all-clusters-app/esp32/sdkconfig.eth.esp32p4 | New example sdkconfig enabling Matter-over-Ethernet on ESP32-P4. |
| config/esp32/components/chip/idf_component.yml | Pins espressif/esp_hosted version for esp32p4. |
| config/esp32/components/chip/Kconfig | Extends ESP32-P4 GPIO range max used by Ethernet pin Kconfig entries. |
|
PR #42862: Size comparison from bd1cc4d to 146b3cd Full report (32 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
|
PR #42862: Size comparison from bd1cc4d to a76274c Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
|
PR #42862: Size comparison from bd1cc4d to 1de3e5c Full report (12 builds for cc13x4_26x4, cc32xx, nrfconnect, qpg, realtek, stm32)
|
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
PR #42862: Size comparison from bd1cc4d to 6011552 Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
|
PR #42862: Size comparison from 9912a4f to 792a7fb Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
PR #42862: Size comparison from 9912a4f to 448b47d Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
PR #42862: Size comparison from 9912a4f to 8d9d657 Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
Summary
We need to add an example sdkconfig for running Matter-over-Ethernet on ESP32-P4
Related issues
N/A (not preferable)
Testing
Run all-clusters-app with the newly added sdkconfig on ESP32-P4 Function EV board. The Ethernet interface got IP address and it can be commissioned