Thread: use tmp path in isolation environment#42840
Thread: use tmp path in isolation environment#42840andy31415 merged 1 commit intoproject-chip:masterfrom
tmp path in isolation environment#42840Conversation
tmp path in isolation environment
There was a problem hiding this comment.
Code Review
This pull request updates several submodules, most notably ot-br-posix, which allows the OpenThread Border Router to use a temporary path for its settings. This change enables the removal of a workaround in scripts/tests/chiptest/linux.py that mounted /var/lib/thread as a temporary filesystem. The code removal is a clean and justified simplification of the test environment. The changes look good.
|
PR #42840: Size comparison from ac0beeb to 4b2a9c0 Full report (31 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, esp32, nrfconnect, psoc6, qpg, realtek, stm32, telink)
|
4b2a9c0 to
24c69a2
Compare
|
PR #42840: Size comparison from ac0beeb to 24c69a2 Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
There was a problem hiding this comment.
Pull request overview
This PR updates the Thread test environment so that OpenThread no longer requires /var/lib/thread inside the isolated environment/container, relying instead on a configurable settings path.
Changes:
- Remove the explicit
/var/lib/threadtmpfs mount from the Linux test helper (ensure_private_state), simplifying the test environment requirements. - Pass
-DOT_POSIX_SETTINGS_PATH='\"tmp\"'to the OTBR CMake build in the GitHub Actions workflow so OpenThread stores settings under atmppath instead of/var/lib/thread.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| scripts/tests/chiptest/linux.py | Drops the special remount of /var/lib/thread since the OTBR now uses a different settings path. |
| .github/workflows/tests.yaml | Configures the OTBR CMake build in CI to use the tmp settings path, aligning with the updated test environment. |
|
Thank you for the fix! |
Summary
This commit changes the OpenThread Border Router settings path to a
tmpso that the/var/lib/threadis not required.Related issues
This was recently reported due to merge of #42336.
Testing
The BLE-Thread test case will cover the change.