[Energy] Water Heater App#42835
Merged
mergify[bot] merged 14 commits intoproject-chip:masterfrom Feb 6, 2026
Merged
Conversation
github-actions
Bot
added
documentation
lpbeliveau-silabs
force-pushed
the
feature/water-heater-app
branch
from
cc5001f to
2be393f
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request successfully refactors the water heater functionality into a standalone application, including updates to build configurations, documentation, and tests. My review focuses on improving consistency, modularity, and correctness across the newly created files. I've identified several areas for improvement, such as correcting copy-paste errors in configuration files, aligning application naming in build scripts, enhancing build file modularity, and fixing a reference to a non-existent directory that would cause build failures. All original comments were retained, with one comment enhanced by a reference to a relevant consistency rule.
lpbeliveau-silabs
force-pushed
the
feature/water-heater-app
branch
from
2be393f to
8904e45
Compare
lpbeliveau-silabs
force-pushed
the
feature/water-heater-app
branch
from
8904e45 to
5698356
Compare
|
PR #42835: Size comparison from ec3f3f2 to 5698356 Full report (5 builds for cc32xx, realtek, stm32)
|
lpbeliveau-silabs
force-pushed
the
feature/water-heater-app
branch
from
5698356 to
07d88ff
Compare
|
PR #42835: Size comparison from ec3f3f2 to 07d88ff Full report (6 builds for cc32xx, nrfconnect, realtek, stm32)
|
lpbeliveau-silabs
force-pushed
the
feature/water-heater-app
branch
4 times, most recently
from
5577420 to
19f6808
Compare
|
PR #42835: Size comparison from ec3f3f2 to 19f6808 Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
lpbeliveau-silabs
force-pushed
the
feature/water-heater-app
branch
from
19f6808 to
fcf05da
Compare
|
PR #42835: Size comparison from 55f0e1f to fcf05da Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
lpbeliveau-silabs
force-pushed
the
feature/water-heater-app
branch
2 times, most recently
from
e3abe67 to
d159bf5
Compare
|
PR #42835: Size comparison from 27b6094 to d159bf5 Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
jamesharrow
reviewed
Feb 5, 2026
jamesharrow
reviewed
Feb 6, 2026
jamesharrow
reviewed
Feb 6, 2026
jamesharrow
approved these changes
Feb 6, 2026
Contributor
jamesharrow
left a comment
jamesharrow
left a comment
There was a problem hiding this comment.
There's a few minor things in the README matter-repl section I've included as suggestions to fix, but once those are merged then happy for this to be merged.
Thanks for the hard work on this!
|
PR #42835: Size comparison from a5400be to 32e970f Full report (5 builds for cc32xx, realtek, stm32)
|
lpbeliveau-silabs
force-pushed
the
feature/water-heater-app
branch
from
32e970f to
da9f486
Compare
…d to common location
Co-authored-by: jamesharrow <93921463+jamesharrow@users.noreply.github.com>
lpbeliveau-silabs
force-pushed
the
feature/water-heater-app
branch
from
da9f486 to
8ed3d4c
Compare
|
PR #42835: Size comparison from aa91661 to ab362f1 Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR continues what was started in #42711,
It implemented the water-heater-app as a standalone app that uses sources from the energy-management common folder.
This PR also attempts at addressing the WHM confusion going on across the example:
According to the spec, WHM stands for the "Water Heater Mode" cluster.
The source apps and various variables have therefore been renamed to address this confusion.
It also re-enables the CI for water-heater tests that were previously disabled.
Related issues
Fixes: #42804
Testing
Build and running has been locally validated, the CI will be instrumental in verifying the rest of the tests.
Readability checklist
The checklist below will help the reviewer finish PR review in time and keep the
code readable:
descriptive
“When in Rome…”
rule (coding style)
See: Pull Request Guidelines