Python test for TC-SMOKECO_2.7#42828
Merged
mergify[bot] merged 10 commits intoproject-chip:masterfrom Feb 19, 2026
Merged
Conversation
|
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
The pull request introduces a new Python test script, TC_SMOKECO_2_7.py, designed to verify the Unmounted attribute functionality within the SmokeCo Alarm cluster for Matter 1.6. The test correctly utilizes the MatterBaseTest framework, including attribute reading, subscription handling, and conditional execution for CI environments versus manual user input. The overall structure and intent of the test are clear and align with the stated objective. A critical syntax error related to an empty 'else' block needs to be addressed.
|
PR #42828: Size comparison from 7df724a to 3315846 Full report (6 builds for cc32xx, nrfconnect, realtek, stm32)
|
|
PR #42828: Size comparison from 7df724a to 6ac759d Increases above 0.2%:
Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
5 tasks
CKnoerzer
force-pushed
the
tc-somkeco-2_7
branch
from
4757574 to
a8dbe08
Compare
|
PR #42828: Size comparison from 429a4d7 to a8dbe08 Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
fessehaeve
approved these changes
Feb 12, 2026
Contributor
Author
|
CI will work once the changes in the SDK are merged (#43043). |
ReneJosefsen
approved these changes
Feb 18, 2026
|
PR #42828: Size comparison from 6921ad7 to c4d2081 Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
|
PR #42828: Size comparison from 6921ad7 to 90b8087 Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a python test script for TC-SMOKECO-2.7
It is about to add an unmounted attribute to the SmokeCo Alarm cluster
Target is Matter 1.6
It is related to this approved TCR: https://github.com/CHIP-Specifications/connectedhomeip-spec/issues/12537
The Spec changed got already merged: https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/12544
The test plan PR: https://github.com/CHIP-Specifications/chip-test-plans/pull/5821
Testing
DUT and CI
CI will work once #43043 is merged.