-
Notifications
You must be signed in to change notification settings - Fork 10
FGD cleanup #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
FGD cleanup #36
Conversation
Used by Jack to preview animation frames (hardcoded KV name)
jjelliott
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with doing this, but I was actually thinking of deleting this as I have no interest in maintaining it anymore, so don't be surprised if it gets out of date again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally think that as we recommend TB, the default FGD being the TB one is preferable. I'll let @dumptruckDS weigh in on this if he wants but I would prefer this not being renamed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The readme and manual actually don't specify a recommended editor. Reverted for now, so that the changes can be read.
Some notable changes:
sequence()andskin()to Jack FGD where appropriateAddrevertedsequencevariable to defs.qc, because Jack needs it to preview animation framesStill working on fixing some syntax errors, but it's 98% done, so I figured I'd push a draft PR to get feedback. This PR is a bit messy, though, so I might need to close it and open a new one if it is to be pushed.