Use NumberField for expiry inputs in character effects dialog

[progressions]

Summary

• Replace TextField type="number" with NumberField components for the end_sequence and end_shot fields in AddEffectModal
• Matches the pattern used in AddFightEffectModal for consistency
• NumberField provides increment/decrement buttons that slide in on hover for better UX

Test plan

• Open an encounter with characters
• Click the + button on a character to add an effect
• Verify the End Sequence and End Shot fields show NumberField components with +/- buttons on hover
• Verify incrementing/decrementing works correctly
• Verify creating an effect with expiry values works

[Copilot]

Pull request overview

Replaces the expiry inputs in the character Add Effect modal with the shared NumberField component to align UI/UX with other effect dialogs and provide increment/decrement controls.

Changes:

• Swap TextField type="number" for NumberField for end_sequence and end_shot.
• Update layout around expiry inputs to use caption labels and fixed-width fields.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

This change drops the previous numeric constraints (min: 1 for end_sequence). With NumberField’s +/- controls, users can now decrement into invalid values (e.g., 0 or negative) and submit them. Please reintroduce a lower bound (e.g., clamp in the onChange handler, or extend NumberField to accept/enforce min).

[Copilot]

The onChange handler here duplicates the existing handleChange("end_sequence") logic (which already handles nullable numeric fields). Reusing the shared handler would reduce duplication and keep numeric parsing behavior consistent across the modal.

[Copilot]

This change drops the previous end_shot bounds (min: 0, max: 30). With NumberField’s +/- controls (and no max), users can now enter negative shots or values > 30 and submit them. Please enforce the expected range (clamp in onChange, or extend NumberField to support min/max and pass them through).

Suggested change

	setEffect(prev => ({
	...prev,
	end_shot: val === "" ? null : Number(val),
	if (val === "") {
	setEffect(prev => ({
	...prev,
	end_shot: null,
	}))
	return
	}
	let num = Number(val)
	if (Number.isNaN(num)) {
	return
	}
	if (num < 0) {
	num = 0
	} else if (num > 30) {
	num = 30
	}
	setEffect(prev => ({
	...prev,
	end_shot: num,

[Copilot]

The new NumberField inputs no longer have an associated form label (the Typography caption isn’t programmatically tied to the input), which is an accessibility regression vs the previous TextField label prop. Consider wiring an accessible label via label/id + htmlFor (or aria-label/aria-labelledby)—either by enhancing NumberField to expose these props properly, or by using a labeled MUI TextField under the hood.