Add expiry UI for character effects#362
Merged
Merged
Conversation
- Add end_sequence and end_shot fields to CharacterEffect type - Add expiry dropdowns to AddEffectModal for setting when effects expire - Display expiry info in CharacterEffectsDisplay popover
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support in the encounter UI for setting and viewing expiry information on character effects.
Changes:
- Extends
CharacterEffectTypeScript type withend_sequence/end_shot. - Adds optional expiry controls (sequence/shot) to
AddEffectModal. - Displays expiry information in the
CharacterEffectsDisplaypopover.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/types/resources.ts | Adds expiry fields to the CharacterEffect type so UI can read/write them. |
| src/components/encounters/effects/AddEffectModal.tsx | Introduces expiry UI inputs and includes expiry values in the payload when creating effects. |
| src/components/encounters/effects/CharacterEffectsDisplay.tsx | Formats and renders expiry text in the effect popover. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Replace dropdown selectors with numeric inputs for expiry fields - Use handleChange for consistent onChange logic - Cache formatExpiry result to avoid calling twice
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
end_sequenceandend_shotfields to CharacterEffect TypeScript typeTest plan
Fizzy card: #405
Depends on: progressions/shot-server-elixir#343