Added updateById, removeById, and completed #todo merge on update. Added tests.

lib/engine.js

@@ -82,24 +82,44 @@ Engine.prototype.count = function (criteria){
  * @returns {bluebird|exports|module.exports}
  */
 Engine.prototype.update = function (criteria, obj){
-     criteria = criteria || {};
+    criteria = criteria || {};
     var self = this;
     var data = this._fetch();
     return new Promise(function (resolve, reject){
         var targets = _.filter(data, criteria);
         var result = [];
         _.forEach(targets, function (target){
-            var index = _.indexOf(data, target);
-            // TODO merge
-            var newObj = obj;
-            result.push(newObj);
-            data.splice(index, 1, newObj);
+            target = _.merge(target, obj);
+            result.push(target);
         });
         self._flush(data);
         resolve(result);
     });
 };
 
+/**
+ * update (PATCH) an object by its _id (auto-generated)
+ * @param criteria
+ * @param obj
+ * @returns {bluebird|exports|module.exports}
+ */
+Engine.prototype.updateById = function (_id, obj){
+    var self = this;
+    var data = this._fetch();
+    return new Promise(function (resolve, reject){
+        var targets = _.filter(data, {_id: _id});
+
+        if (targets.length > 1) reject(new Error('duplicate _id found'))
+        if (targets.length === 0) reject(new Error('no object found'))
+
+        var target = targets[0]
+        target = _.merge(target, obj);
+
+        self._flush(data);
+        resolve(target);
+    });
+};
+
 /**
  * insert obj
  * @param obj
@@ -129,6 +149,21 @@ Engine.prototype.remove = function (criteria){
     });
 };
 
+/**
+ * removes an object by its _id (auto-generated)
+ * @param criteria
+ * @returns {bluebird|exports|module.exports}
+ */
+Engine.prototype.removeById = function (_id){
+    var data = this._fetch();
+    var targets = _.remove(data, {_id: _id});
+    this._flush(data);
+    return new Promise(function (resolve, reject){
+        if (targets.length > 0) return resolve(targets[0])
+        return resolve([])
+    });
+};
+
 /**
  * fetch data from local file
  * @private

test/removeById.js

@@ -0,0 +1,45 @@
+/**
+ * Created by fpicoitoj on 2017/6/21.
+ */
+
+var path = require('path');
+var assert = require("assert");
+var user = require('..')(path.join(__dirname, 'data/user.json'));
+var userId = -1
+
+describe('node-localdb', function() {
+    describe('#removeById()', function () {
+        before(function() {
+            // remove all data
+            user.remove({}).then(function(){});
+        });
+        after(function() {
+            // remove all data
+            user.remove({}).then(function(){});
+        });
+
+        it('should hash method of #removeById()', function(){
+            assert.notEqual(undefined, user.removeById);
+            assert.equal('function', typeof user.removeById);
+        });
+        it('should return object when the there is one user in user document', function (done) {
+            user.insert({username: 'jf', password: '123'}).then(function(u){
+                userId = u._id; // save auto generated _id
+
+                assert.notEqual(undefined, u);
+                assert.notEqual(undefined, u.username);
+                assert.notEqual(undefined, u.password);
+                assert.equal('jf', u.username);
+                assert.equal('123', u.password);
+                assert.notEqual(undefined, u._id);
+            }).then(function(){
+                user.removeById(userId);
+            }).then(function(){
+                user.findOne({}).then(function(u){
+                    assert.equal(undefined, u);
+                    done();
+                });
+            });
+        });
+    });
+});

test/update.js

@@ -0,0 +1,81 @@
+/**
+ * Created by fpicoitoj on 2017/6/21.
+ */
+
+var path = require('path');
+var assert = require("assert");
+var user = require('..')(path.join(__dirname, 'data/user.json'));
+var _ = require('lodash')
+
+describe('node-localdb', function() {
+    describe('#update()', function () {
+        before(function() {
+            // remove all data
+            user.remove({}).then(function(){});
+        });
+        after(function() {
+            // remove all data
+            user.remove({}).then(function(){});
+        });
+
+        it('should hash method of #update()', function(){
+            assert.notEqual(undefined, user.update);
+            assert.equal('function', typeof user.update);
+        });
+
+        it('should create two users with same field value', function (done) {
+            user.insert({username: 'jf', password: '123', active: true}).then(function(u){
+                assert.notEqual(undefined, u);
+                assert.notEqual(undefined, u.username);
+                assert.notEqual(undefined, u.password);
+                assert.notEqual(undefined, u.active);
+                assert.equal('jf', u.username);
+                assert.equal('123', u.password);
+                assert.equal(true, u.active);
+                assert.notEqual(undefined, u._id);
+            }).then(function(){
+                user.insert({username: 'fpj', password: '313', active: true}).then(function(u){
+                    assert.notEqual(undefined, u);
+                    assert.notEqual(undefined, u.username);
+                    assert.notEqual(undefined, u.password);
+                    assert.notEqual(undefined, u.active);
+                    assert.equal('fpj', u.username);
+                    assert.equal('313', u.password);
+                    assert.equal(true, u.active);
+                    assert.notEqual(undefined, u._id);
+                });
+            }).then(function(){
+                user.find({}).then(function(users){
+                    assert.notEqual(undefined, users);
+                    assert.equal('object', typeof users);
+                    assert.equal(true, users instanceof Array);
+                    assert.equal(2, users.length);
+                    assert.deepEqual(_.pick(users[0], ['username', 'password', 'active']), {username: 'jf', password: '123', active: true})
+                    assert.deepEqual(_.pick(users[1], ['username', 'password', 'active']), {username: 'fpj', password: '313', active: true})
+                    done();
+                });
+            });
+        });
+
+        it('should update two users with same field value and add another field', function (done) {
+            user.update({active: true}, {active: false, age: 31}).then(function(users){
+                assert.notEqual(undefined, users);
+                assert.equal('object', typeof users);
+                assert.equal(true, users instanceof Array);
+                assert.equal(2, users.length);
+                assert.deepEqual(_.pick(users[0], ['username', 'password', 'active', 'age']), {username: 'jf', password: '123', active: false, age: 31});
+                assert.deepEqual(_.pick(users[1], ['username', 'password', 'active', 'age']), {username: 'fpj', password: '313', active: false, age: 31});
+            }).then(function(){
+                user.find({}).then(function(users){
+                    assert.notEqual(undefined, users);
+                    assert.equal('object', typeof users);
+                    assert.equal(true, users instanceof Array);
+                    assert.equal(2, users.length);
+                    assert.deepEqual(_.pick(users[0], ['username', 'password', 'active', 'age']), {username: 'jf', password: '123', active: false, age: 31});
+                    assert.deepEqual(_.pick(users[1], ['username', 'password', 'active', 'age']), {username: 'fpj', password: '313', active: false, age: 31});
+                    done();
+                });
+            });
+        });
+    });
+});