fix: expose missing NumberListNode from index export #2010
Merged
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: I'm making a library called scrapbox-parser-to-markdown that takes the output of scrapbox-parser and converts it to markdown. In this library, I need the `NumberListNode` type to type things correctly. Since other nodes are already exposed from `index.ts`, I think it's more natural to expose `NumberListNode` as well. See how I use `NumberListNode` in my codebase: https://github.com/0b5vr/scrapbox-parser-to-markdown/blob/bc7f7a9511c68f19aa5fef5e464cc1042912f57f/src/nodeToMarkdown.ts#L77 Workaround: `type NumberListNode = Extract<Node, { type: 'numberList' }>;` would work.
progfay
approved these changes
Dec 10, 2025
Owner
progfay
left a comment
progfay
left a comment
There was a problem hiding this comment.
Thank you for your contribution, LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
I exposed missing
NumberListNodefrom the index.ts exports.Context
I'm making a library called scrapbox-parser-to-markdown that takes the output of scrapbox-parser and converts it to markdown. In this library, I need the
NumberListNodetype to type things correctly. Since other nodes are already exposed fromindex.ts, I think it's more natural to exposeNumberListNodeas well.See how I use
NumberListNodein my codebase: https://github.com/0b5vr/scrapbox-parser-to-markdown/blob/bc7f7a9511c68f19aa5fef5e464cc1042912f57f/src/nodeToMarkdown.ts#L77Workaround
type NumberListNode = Extract<Node, { type: 'numberList' }>;would work.