Skip to content

Comments

Create proffieboard_v3_sabersense_sample.h#885

Open
Sabersense-CC wants to merge 7 commits intoprofezzorn:masterfrom
Sabersense-CC:patch-18
Open

Create proffieboard_v3_sabersense_sample.h#885
Sabersense-CC wants to merge 7 commits intoprofezzorn:masterfrom
Sabersense-CC:patch-18

Conversation

@Sabersense-CC
Copy link
Contributor

A really easy-to-build config starter for people new to Proffie. I've configured it to use the Proffie default fonts, but the idea is people can simply duplicate presets, add their own font folder name, set the colour and they're good to go really quickly and easily, with some great styles and user-controlled colours right out of the box. It also includes the Array Selector configured to be able to adjust for different blade lengths just using the buttons.

A really easy-to-build config starter for people new to Proffie. I've configured it to use the Proffie default fonts, but the idea is people can simply duplicate presets, add their own font folder name, set the colour and they're good to go really quickly and easily, with some great styles and user-controlled colours right out of the box. It also includes the Array Selector configured to be able to adjust for different blade lengths just using the buttons.
Number typo fixed! Doh!
Spotted some double line spaces. Now tidied.
Index fixed after line space tidy up.
@profezzorn
Copy link
Owner

"base" tends to mean "base class" in C++, and this is not a base class, so I would like to have a different filename.
Maybe "proffieboard_v3_sabersense_sample.h" ?

Understood.
Yes proffieboard_v3_sabersense_sample.h sounds good to me. Although does it need the v3 given that it will work with any Proffie?
But yes, I can see in the folder currently that it ties in with other naming conventions, so yes, I'm happy to go with whatever you think, so I've changed it accordingly.
@profezzorn
Copy link
Owner

Although does it need the v3 given that it will work with any Proffie?

Not really, it's just how other files in that directory are named.

@Sabersense-CC
Copy link
Contributor Author

Although does it need the v3 given that it will work with any Proffie?

Not really, it's just how other files in that directory are named.

Fair enough. Well I'm happy to follow convention and go with your suggestion. I've been experimenting with other names, but yours is the most descriptive for what the file is. :)

@Sabersense-CC
Copy link
Contributor Author

Having slept on it,
sabersense_starter_config.h
works as a description for me.

But I completely get that you might prefer to stick with your convention of
proffieboard_v3_sabersense_sample.h
to tie in with the other configs.

I'm easy Prof - whatever works best for you is fine by me. Just say the word and I'll change/leave it accordingly.

While testing the Fett BladeID, I realised I'd omitted an important details from my own prop's BladeID notes, Now fixed.
@Sabersense-CC Sabersense-CC changed the title Create sabersense_base_config.h Create proffieboard_v3_sabersense_sample.h Feb 20, 2026
I initially omitted these, but having thought about it, I think they might be useful - especially as the indexing and layout makes it easy for people to skip sections they don't need.
I hope overall that what I've done with this file is easily navigable. This is why I put the CONFIG_STYLES section before CONFIG_TP, as it means that the parts that people actually need to edit are all in one place together.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants