Skip to content

Add a method get_all_staff_in_all_packages() for more sane querysets#130

Merged
profcturner merged 3 commits intomasterfrom
ct-2026-01-26
Jan 26, 2026
Merged

Add a method get_all_staff_in_all_packages() for more sane querysets#130
profcturner merged 3 commits intomasterfrom
ct-2026-01-26

Conversation

@profcturner
Copy link
Owner

A challenge is having a useful collection of staff in drop down menus.

  • all staff can be overwhelming and increase the chance of incorrect staff being added
  • package.get_all_staff() is used in many places, and works quite well but
  • staff.get_all_staff_for_all_packages() is useful for admins working across several packages.

A new set of tests have been added to verify this behaviour.

I also found that if one created a non validating form in a formset, you couldn't delete it without an exception.

@profcturner profcturner merged commit 841d0b9 into master Jan 26, 2026
3 checks passed
@profcturner profcturner deleted the ct-2026-01-26 branch January 26, 2026 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant