Skip to content

Fix: Add property w JSDoc block after property #8154#8936

Open
vamshi567bh wants to merge 2 commits into
processing:mainfrom
vamshi567bh:fix/vector-w-property
Open

Fix: Add property w JSDoc block after property #8154#8936
vamshi567bh wants to merge 2 commits into
processing:mainfrom
vamshi567bh:fix/vector-w-property

Conversation

@vamshi567bh

@vamshi567bh vamshi567bh commented Jun 18, 2026

Copy link
Copy Markdown

Resolves #8154

Changes

Add @property w JSDoc block for p5.Vector alongside the existing x, y, z property blocks. The w component was already implemented as a getter/setter but was missing from the documentation definition, so it never appeared in the generated reference docs.

PR Checklist

  • npm run lint passes
  • npm test passes
  • npm run docs generates correct data with w as a p5.Vector member

screenshot

done 2

@vamshi567bh

Copy link
Copy Markdown
Author

@ksen0 please check when you have time thanks!

@vamshi567bh vamshi567bh marked this pull request as draft June 18, 2026 03:23
@vamshi567bh vamshi567bh marked this pull request as ready for review June 18, 2026 08:23
@vamshi567bh vamshi567bh marked this pull request as draft June 18, 2026 08:27
@vamshi567bh vamshi567bh marked this pull request as ready for review June 18, 2026 11:23
@ksen0

ksen0 commented Jun 18, 2026

Copy link
Copy Markdown
Member

Hi @vamshi567bh welcome! In the future please wait to be assigned before making the PR (this is part of the contributor guidelines, please review those as well)

Please update issue description with a screenshot verifying the fix worked. This is the guide for testing locally

Thanks!

@vamshi567bh

Copy link
Copy Markdown
Author

@ksen0 thansk for the replie i have upadted discription with locally tests passed thanks!

@ksen0

ksen0 commented Jun 18, 2026

Copy link
Copy Markdown
Member

@vamshi567bh I meant screenshot of the website running locally and having the valid entry for w (should be different than https://beta.p5js.org/reference/p5/p5.Vector/w) thanks!

@vamshi567bh

vamshi567bh commented Jun 18, 2026

Copy link
Copy Markdown
Author

@ksen0 really sorry for misunderstanding please check now thanks!

updated discription thanks !
done 2
with this

@p5-bot

p5-bot Bot commented Jun 19, 2026

Copy link
Copy Markdown

Continuous Release

CDN link

Published Packages

Commit hash: d0d000b

Previous deployments

This is an automated message.

@vamshi567bh

vamshi567bh commented Jun 19, 2026

Copy link
Copy Markdown
Author

@ksen0 this fail is not realted to my changes please rerun the checks thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[2.0] Include w field of p5.Vector in documentation

2 participants