-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Refactor p5.Vector to prioritize smaller dimension in binary operations on mismatched-size vectors #8676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ksen0
wants to merge
19
commits into
processing:dev-2.0
Choose a base branch
from
ksen0:vector-smaller-priority
base: dev-2.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+801
−562
Draft
Refactor p5.Vector to prioritize smaller dimension in binary operations on mismatched-size vectors #8676
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
e9c9d96
Implement pad zero proof of concept
limzykenneth b12d6f9
Merge branch 'dev-2.0' into vector-pad-zero
limzykenneth 80ac3cd
Merge branch 'dev-2.0' into vector-smaller-priority
limzykenneth 124a60e
Vector use values property directly and calculate dimension
limzykenneth 04a2f24
Implement vector smaller size priority
limzykenneth 043e668
Merge remote-tracking branch 'og/dev-2.0' into vector-smaller-priority
ksen0 492b9e9
Vector decorator does not use Proxy
ksen0 93920ba
Abstract out vector format and dimension checks for binary vector ops
ksen0 f258b5e
Added tests
ksen0 346a2ac
Added benchmark tests
ksen0 7171ab9
Merge branch 'dev-2.0' into vector-smaller-priority
ksen0 e5df5f9
Updating tests for vectors - unit and bench
ksen0 613df14
Update vector documentation
ksen0 ce6a048
Operation logic in helpers
ksen0 a84505e
shared abstraction for vector validation
ksen0 b2c5185
Vector tests pass
ksen0 9a534d5
Merge branch 'dev-2.0' into vector-smaller-priority
ksen0 719b4bd
Update createVector doc
ksen0 32e351a
Prevent minification mangling from messing up decoration
limzykenneth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is done only in
p5.Vector.