-
Notifications
You must be signed in to change notification settings - Fork 190
Adding Mermaid diagram support #168 #1044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…size but rather h4<small>, because git doesnt recognize font size either
Uploading Hien's branch to Main fork branch (NOT OFFICIAL PR)
This reverts commit e32991e.
Pushing Hien Branch onto main #2
… for dark—because Mermaid diagrams are rendered at build time and can’t switch themes dynamically. Each version is wrapped in its own container using a html script, and CSS rules in global.scss hide or show the appropriate diagram depending on whether the .dark-theme class is active. This ensures users always see a diagram that matches their current theme
|
Thank you for your work on this! The dark mode not showing up I think is not a major blocker; this can be a follow up issue. Alternatively, if you have capacity to investigate further, you could see if it's possible to add an invert filter? Either as a style
Or, preferably, using the invert-in-dark class which is intended for this use: p5.js-website/styles/global.scss Line 412 in 760d903
cc @davepagurek |
|
Hi @ksen0, thanks for your reply. |


Co-authored-by: Hien T Ly hien.ly@sjsu.edu
Co-authored-by: Jaime Serrano Acevedo xilverscott@gmail.com
Resolves -> Adding Mermaid Diagram Support #168
Changes
Notes:
Screenshots of the diagram below
--- Before the changes ---

In git hub:

--- After the fix ---

Mermaid diagram in dark mode:

In git gub:
