Merged
Conversation
lucasloisp
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a broad set of access modifier changes across the SDK, changing many classes, interfaces, enums, and static classes from
publictointernal. This restricts their visibility to within the assembly, which is a common practice to encapsulate implementation details and reduce the public API surface area. Additionally, there is a minor import addition inBrowserDomIframeHandler.csto include a utility namespace.The most important changes are:
Access Modifier Restriction (Encapsulation):
ClientAnalyticsIdRepository.cs,IClientAnalyticsIdRepository.cs,AuthDelegator.cs,PKCE.cs,WebGLPopupMessageInterceptor.cs,IWebviewHandler.cs,PrivyEventType.cs,WebViewHandlerForUnsupportedPlatform.cs, andPrivyLogger.csfrompublictointernal, restricting their visibility to within the assembly. This includes all request/response and data model classes inWebView.cs. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20] [21] [22] [23] [24] [25] [26] [27] [28] [29] [30]Dependency Update:
using Privy.Utils;import toBrowserDomIframeHandler.csto enable usage of utilities in that file.These changes help enforce encapsulation and clarify which types are intended for internal use versus public consumption, making the SDK's API surface more intentional and maintainable.