Upgrade to Rust 1.93#1533
Merged
akoshelev merged 7 commits intoprivate-attribution:mainfrom Feb 17, 2026
Merged
Conversation
Remove unused `pin` import from `helpers/transport/receive.rs` and `query/runner/reshard_tag.rs`.
Member
martinthomson
left a comment
martinthomson
left a comment
There was a problem hiding this comment.
This all looks fine, but why isn't it building? (Why bother being the other question...)
Gate `OrderedStream` struct and its `Stream` impl behind `#[cfg(all(test, ...))]` since it is only used in tests. Remove unused `metrics::Request` struct from `http_serde.rs` and unused `QueryType`/`Node` enums from `ipa_bench/models.rs`.
Provide descriptive reasons for `#[ignore]` tests, satisfying `clippy::ignore_without_reason`.
Add backticks around code references in doc comments to satisfy `clippy::doc_markdown`.
akoshelev
force-pushed
the
clippy-fixes
branch
from
7483684 to
23d38c3
Compare
Collaborator
Author
nostalgic notes and want to keep this code alive just in case if I need to borrow any ideas from it |
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (65.38%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #1533 +/- ##
==========================================
- Coverage 91.88% 91.74% -0.14%
==========================================
Files 220 214 -6
Lines 38464 33929 -4535
==========================================
- Hits 35343 31129 -4214
+ Misses 3121 2800 -321 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Use `.clone()` instead of `.to_string()` on `String` derefs (`clippy::implicit_clone`) - Replace `is_some()`/`unwrap()` with `if let Some` (`clippy::unnecessary_unwrap`) - Remove needless `return` statements (`clippy::needless_return`) - Derive `Default` instead of manual impl (`clippy::derivable_impls`) - Use `std::slice::from_ref` instead of `&[x.clone()]` (`clippy::cloned_ref_to_slice_refs`)
akoshelev
force-pushed
the
clippy-fixes
branch
from
23d38c3 to
96f828f
Compare
The metrics collector thread spawned by install_collector() was never joined before process exit. CollectorHandle::drop() only logged a warning if the thread was still running, but did not stop or join it. When running tests with `-Z sanitizer=leak`, LSan's atexit handler races against the still-running metrics thread. If LSan runs its leak check before the thread processes the channel disconnect and terminates, it sees the thread's live allocations as leaks and exits with code 23. Fix by properly shutting down the metrics thread in Drop.
Collaborator
Author
|
sorry, coverage, not today |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various clippy fixes