Upgrade IPA to Rust 2024 edition

[akoshelev]

For some reason formatting rules have changed it seems from 2021 to 2024 so there is a lot of noise here.

Other than that, there are only two major things

• gen is a reserved word now
• Compiler rules over capturing lifetimes changed.

[codecov]

Codecov Report

Attention: Patch coverage is 96.50259% with 27 lines in your changes missing coverage. Please review.

Project coverage is 91.89%. Comparing base (ab46b0f) to head (705b534).
Report is 8 commits behind head on main.

Files with missing lines	Patch %	Lines
ipa-core/src/report/hybrid_info.rs	66.66%	6 Missing ⚠️
ipa-core/src/cli/playbook/mod.rs	0.00%	4 Missing ⚠️
ipa-core/src/report/hybrid.rs	86.36%	3 Missing ⚠️
ipa-core/src/app.rs	0.00%	2 Missing ⚠️
ipa-core/src/bin/report_collector.rs	0.00%	2 Missing ⚠️
ipa-core/src/protocol/context/semi_honest.rs	50.00%	2 Missing ⚠️
ipa-core/src/bin/ipa_bench/cmd.rs	0.00%	1 Missing ⚠️
ipa-core/src/cli/metric_collector.rs	0.00%	1 Missing ⚠️
ipa-core/src/cli/verbosity.rs	0.00%	1 Missing ⚠️
ipa-core/src/helpers/buffers/ordering_sender.rs	83.33%	1 Missing ⚠️
... and 4 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1532      +/-   ##
==========================================
+ Coverage   91.81%   91.89%   +0.07%     
==========================================
  Files         220      220              
  Lines       38229    38464     +235     
==========================================
+ Hits        35099    35345     +246     
+ Misses       3130     3119      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[akoshelev]

@andyleiserson @martinthomson it is ready for review now

[martinthomson]

This all looks like rustfmt changes for the most part. Is there anything in particular I need to be looking at, or is this a case where I just trust Alex?

[martinthomson]

No sense in using SmallVec here, is there?

[akoshelev]

probably no reason just yet as I don't think this one is on the hot path

[martinthomson]

Is the rand crate getting updated? This is pretty unfortunate.

[akoshelev]

yes, it is updated and the latest version (0.9 I believe) does not have this method anymore. Not every crate that IPA uses and depends on rand migrated over :(

[akoshelev]

This all looks like rustfmt changes for the most part. Is there anything in particular I need to be looking at, or is this a case where I just trust Alex?

I would say this is the case we should trust our CI to catch issues. You're right - most changes are just rustfmt