Skip to content

Docs fix spelling issues#152

Merged
arnaucube merged 4 commits intoprivacy-ethereum:typos-aggrfrom
nnsW3:docs-fix-spelling-issues
Nov 19, 2024
Merged

Docs fix spelling issues#152
arnaucube merged 4 commits intoprivacy-ethereum:typos-aggrfrom
nnsW3:docs-fix-spelling-issues

Conversation

@nnsW3
Copy link
Copy Markdown
Contributor

@nnsW3 nnsW3 commented Aug 28, 2024

Hello
I found several spelling issues.
Hope it helps
Br, Elias.

@arnaucube
Copy link
Copy Markdown
Collaborator

Hi @nnsW3 , thanks for the typos fixes. In this repo some months ago we added into the CI pipeline the tool typos to prevent many typos from happening, but it will only detect miss-spellings of words, not wrong usages or errors on sentences as the ones that you're fixing in this PR.

From what I see in your github profile, eg. Cyfrin/foundry-full-course-cu#2301, starkware-libs/blockifier#2108, near/nearcore#11906, matter-labs/zksync-era#2611 , etc (more than 100 PRs to different projects fixing typos), seems like you're using some more advanced tool to detect these kind of typos that are not misspelling of words but more like sentence errors or wrong usage of words.

Is it some tool that we could integrate in the CI pipeline of this repo, so that future similar typos can be automatically detected avoiding more human friction?
Thanks in advance.

@CPerezz
Copy link
Copy Markdown
Contributor

CPerezz commented Oct 2, 2024

Seems he's not going to get back to us. Likely a script that is farming airdrops.

@CPerezz
Copy link
Copy Markdown
Contributor

CPerezz commented Oct 2, 2024

Can we close this @arnaucube? SO we have less PRs to navigate through

@nnsW3
Copy link
Copy Markdown
Contributor Author

nnsW3 commented Oct 2, 2024

Hi @nnsW3 , thanks for the typos fixes. In this repo some months ago we added into the CI pipeline the tool typos to prevent many typos from happening, but it will only detect miss-spellings of words, not wrong usages or errors on sentences as the ones that you're fixing in this PR.

From what I see in your github profile, eg. Cyfrin/foundry-full-course-cu#2301, starkware-libs/blockifier#2108, near/nearcore#11906, matter-labs/zksync-era#2611 , etc (more than 100 PRs to different projects fixing typos), seems like you're using some more advanced tool to detect these kind of typos that are not misspelling of words but more like sentence errors or wrong usage of words.

Is it some tool that we could integrate in the CI pipeline of this repo, so that future similar typos can be automatically detected avoiding more human friction? Thanks in advance.

no, I have done it manually and spent a lot of time finding errors
I just try to contribute to the space with my knowledge. I'm just a junior developer yet...
so more meaningful contributions are out of my hand for now...

@arnaucube
Copy link
Copy Markdown
Collaborator

But, are you reading line by line all those repositories where you open PRs fixing issues in order to find those kind of typos? We're talking about more than 100 PRs to 100 different repos, each of them with thousands lines of code. I would use some tool instead.

I was asking because maybe we can integrate that tool in the CI so that in the future similar typos are detected automatically.

@arnaucube arnaucube changed the base branch from main to typos-aggr November 19, 2024 18:57
@arnaucube arnaucube merged commit 61fd5fe into privacy-ethereum:typos-aggr Nov 19, 2024
arnaucube pushed a commit that referenced this pull request Nov 29, 2024
* Update nimfs.rs

* Update utils.rs

---------
arnaucube pushed a commit that referenced this pull request Dec 20, 2024
* Update nimfs.rs

* Update utils.rs

---------
arnaucube pushed a commit that referenced this pull request Dec 26, 2024
* Update nimfs.rs

* Update utils.rs

---------
arnaucube pushed a commit that referenced this pull request Jan 1, 2025
* Update nimfs.rs

* Update utils.rs

---------
arnaucube pushed a commit that referenced this pull request Jan 12, 2025
* Update nimfs.rs

* Update utils.rs

---------
arnaucube pushed a commit that referenced this pull request Jan 22, 2025
* Update nimfs.rs

* Update utils.rs

---------
arnaucube pushed a commit that referenced this pull request Jan 22, 2025
* Update nimfs.rs

* Update utils.rs

---------
arnaucube pushed a commit that referenced this pull request Feb 17, 2025
* Update nimfs.rs

* Update utils.rs

---------
arnaucube pushed a commit that referenced this pull request Feb 19, 2025
* Update nimfs.rs

* Update utils.rs

---------
github-merge-queue Bot pushed a commit that referenced this pull request Feb 24, 2025
* Docs: Fix Typo (#174)

There is a typo in the text

* Docs fix spelling issues (#152)


* Update nimfs.rs

* Update utils.rs

---------

* Typo Update README.md (#175)

Corrected preposition in the solidity-verifiers description

* docs fix spelling issues (#178)

* Update README.md

* Update README.md

* Update README.md

* Fix typographical errors in documentation and comments (#192)

* typo kzg.rs

* typo virtual_polynomial.rs

* typo gadgets.rs

* typo nova.rs

* fix: typos in documentation files (#190)

* Update main.rs

* Fix rustfmt errors

---------

Co-authored-by: Игорь <igor@MacBook-Pro.local>

* Fix spelling (#194)

* Fix spelling kzg.rs

* Fix spelling virtual_polynomial.rs

* Fix spelling gadgets.rs

* chore: remove redundant words in comment (#187)

* chore: fix some typos (#198)

---------

Co-authored-by: Oleg <operagxsasha@gmail.com>
Co-authored-by: Elias Rad <146735585+nnsW3@users.noreply.github.com>
Co-authored-by: Bryer <0xbryer@gmail.com>
Co-authored-by: planetBoy <140164174+Guayaba221@users.noreply.github.com>
Co-authored-by: Marco <wudmytrotest200@gmail.com>
Co-authored-by: fuder.eth <139509124+vtjl10@users.noreply.github.com>
Co-authored-by: Игорь <igor@MacBook-Pro.local>
Co-authored-by: Ocenka <testoviydiman1@gmail.com>
Co-authored-by: withbest <seekseat@outlook.com>
Co-authored-by: fanqiaojun <fanqiaojun@yeah.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants