resolved TODO comments in db.py and library.py#92
Open
owenyu23 wants to merge 1 commit into
Open
Conversation
Member
|
Thanks @owenyu23 - I don't have a clear context of what we're trying to do here (and why). If the intention is to match the python implementation to the original Clojure code, can you also include links to the relevant lines in the Clojure code? |
Member
|
@owenyu23 - let's move development to the fork of this repo at https://github.com/vineetbansal/guidescanpy. I've sent you an invite. That way at least we have the assurance of the CI working while we're making changes. Can you retarget any pending PRs to that fork instead? At some point we can do a merge to this repo, with or without the CI working here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressed TODO comments in db.py and removed TODO comments in library.py based on edits done in db.py:
Note that there are two TODOs (one in db.py and library.py) that still need addressing: