-
Notifications
You must be signed in to change notification settings - Fork 871
DR-6749 added /docs to multiple search results to counter 404 errors
#7434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Dangerous URL checkNo absolute URLs to prisma.io/docs found. |
WalkthroughThis PR updates redirect paths in five error documentation files from Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes This is a homogeneous, repetitive change applied uniformly across all files with no logic density, structural complexity, or conditional reasoning required per file. All five files follow an identical modification pattern, making this a straightforward verification task. Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
Redirect checkThis PR probably requires the following redirects to be added to static/_redirects:
|
Deploying docs with
|
| Latest commit: |
cfb6ad3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://361e716e.docs-51g.pages.dev |
| Branch Preview URL: | https://6749-404s-returned-in-search.docs-51g.pages.dev |
/docs to multiple search results to counter 404 errors/docs to multiple search results to counter 404 errors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @content/200-orm/500-reference/300-errors/migrate-no-foreign-keys.mdx:
- Line 8: The Redirect in migrate-no-foreign-keys.mdx uses an incorrect target
with a "/docs" prefix; update the Redirect component's to value to
"/orm/overview/databases/planetscale#option-1-emulate-relations-in-prisma-client"
(remove the "/docs" prefix) and apply the same fix to the other affected files
that use Redirect (mongodb-replica-set.mdx, migrate-shadow.mdx,
migrate-resolve.mdx, migrate-provider-switch.mdx) so all targets follow the
established "/orm/..." routing pattern.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
content/200-orm/500-reference/300-errors/migrate-no-foreign-keys.mdxcontent/200-orm/500-reference/300-errors/migrate-provider-switch.mdxcontent/200-orm/500-reference/300-errors/migrate-resolve.mdxcontent/200-orm/500-reference/300-errors/migrate-shadow.mdxcontent/200-orm/500-reference/300-errors/mongodb-replica-set.mdx
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2026-01-06T22:06:57.725Z
Learnt from: newclarityex
Repo: prisma/docs PR: 7425
File: content/200-orm/050-overview/500-databases/400-mysql.mdx:80-80
Timestamp: 2026-01-06T22:06:57.725Z
Learning: In Prisma docs, when showing examples of instantiating driver adapters with connection strings from environment variables, use the template literal pattern `const connectionString = `${process.env.DATABASE_URL}`` for consistency across all database adapter examples (PostgreSQL, MySQL/MariaDB, etc.).
Applied to files:
content/200-orm/500-reference/300-errors/migrate-no-foreign-keys.mdxcontent/200-orm/500-reference/300-errors/mongodb-replica-set.mdxcontent/200-orm/500-reference/300-errors/migrate-shadow.mdxcontent/200-orm/500-reference/300-errors/migrate-resolve.mdxcontent/200-orm/500-reference/300-errors/migrate-provider-switch.mdx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Check internal links
🔇 Additional comments (4)
content/200-orm/500-reference/300-errors/mongodb-replica-set.mdx (1)
8-8: LGTM! Redirect path correctly prefixed.The
/docsprefix addition follows the same pattern as the other files in this PR. The anchor#how-to-use-mongodb-replica-setsshould correctly deep-link users to the relevant section.content/200-orm/500-reference/300-errors/migrate-shadow.mdx (1)
8-8: LGTM! Redirect updated consistently.This follows the same
/docsprefix pattern applied across the PR. Users searching for shadow database error information will now be correctly routed to the documentation.content/200-orm/500-reference/300-errors/migrate-provider-switch.mdx (1)
8-8: LGTM! Redirect path updated correctly.The
/docsprefix is properly added. The specific anchor#you-cannot-automatically-switch-database-providersensures users land exactly where they need to be when encountering this error.content/200-orm/500-reference/300-errors/migrate-resolve.mdx (1)
8-8: Redirect target is valid and anchor exists.The redirect in
migrate-resolve.mdxcorrectly points to/docs/orm/prisma-migrate/workflows/patching-and-hotfixing#failed-migration, where the "Failed migration" heading exists at line 71 of the target file.However, I need to flag an issue with the broader claims in this review: there are actually 13 redirect files in the codebase, not 5. More importantly, redirect usage is inconsistent—some use the
/docsprefix (likemigrate-resolve,mongodb-replica-set,migrate-shadow,migrate-no-foreign-keys) while others don't (likeconnection-pool,migrate-no-direct-ddl,migrate-baseline,migrate). The claim that "all five redirect files in this PR now consistently use the/docsprefix" doesn't hold up to scrutiny.If this PR only touches a subset of files, that's fine—but the characterization of consistency should be more precise about scope.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.