Fix implicit multiplication priority#323
Draft
probablykasper wants to merge 6 commits intoprintfn:mainfrom
Draft
Fix implicit multiplication priority#323probablykasper wants to merge 6 commits intoprintfn:mainfrom
probablykasper wants to merge 6 commits intoprintfn:mainfrom
Conversation
6b4358f to
b7b78e2
Compare
Contributor
Author
|
Any thoughts/feedback/tips @printfn? Do you agree that this change make sense? Also, what is |
Owner
|
I haven't had a change to look at the code yet, but in theory this seems like a good change, assuming we can get it to work without too many breakages 😅
|
Contributor
Author
|
@printfn Wanna have a look at the code? I'm not really sure how to go forward |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This results in
1m / 1mbeing parsed as(1m)/(1m)instead of((1m)/1)mwhich is a step towards what I wrote in #76 (comment).Notes/todo:
1 kgsomehow gets turned intonumber 1000/1000 k-g (= 1000/1000 kilogram^-1) (base 10, auto, simplifiable)parse_power()calls that should be replaced byparse_implicit_multiplication()1 % 1mis no longer possible with this. In my opinion that's good, but you may disagree