Skip to content

feat: add React Compiler support for more components#8055

Open
joshblack wants to merge 1 commit into
mainfrom
copilot/react-compiler-no-change-components
Open

feat: add React Compiler support for more components#8055
joshblack wants to merge 1 commit into
mainfrom
copilot/react-compiler-no-change-components

Conversation

@joshblack

Copy link
Copy Markdown
Member

Closes N/A

Changelog

New

N/A

Changed

  • Enabled React Compiler support for Autocomplete, Banner, Button, ConfirmationDialog, Dialog, PageLayout, Pagination, SelectPanel2, and UnderlineNav.
  • Added a patch changeset for the rendering performance improvement.

Removed

N/A

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

  • npx eslint --no-cache packages/react/src/Autocomplete/**/*.{ts,tsx} packages/react/src/Banner/**/*.{ts,tsx} packages/react/src/Button/**/*.{ts,tsx} packages/react/src/ConfirmationDialog/**/*.{ts,tsx} packages/react/src/Dialog/**/*.{ts,tsx} packages/react/src/PageLayout/**/*.{ts,tsx} packages/react/src/Pagination/**/*.{ts,tsx} packages/react/src/UnderlineNav/**/*.{ts,tsx} packages/react/src/experimental/SelectPanel2/**/*.{ts,tsx}
  • Focused tests for Autocomplete, Banner, Button, ConfirmationDialog, Dialog/DialogV1, PageLayout, Pagination, UnderlineNav, and SelectPanel2.
  • npm run build && npm test -- --run && npm run type-check && npm run lint && npm run lint:css && npm run format:diff
  • Storybook started and responded locally at http://localhost:6006.

ActionMenu, SelectPanel, and TooltipV2 were intentionally left on the ignore list because their focused tests fail after enabling React Compiler and should be migrated in separate PRs with code changes.

Merge checklist

  • Added/updated tests (not needed; existing coverage validated)
  • Added/updated documentation (not needed)
  • Added/updated previews (not needed)
  • Changes are SSR compatible
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge
  • (GitHub staff only) Integration tests pass at github/github-ui (Learn more about how to run integration tests)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@changeset-bot

changeset-bot Bot commented Jun 24, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 47df1c7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added the staff Author is a staff member label Jun 24, 2026
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Action required

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. If this doesn't work, you can also use the original workflow here. Check the integration testing docs for step-by-step instructions. Or, apply the integration-tests: skipped manually label to skip these checks.

To publish a canary release for integration testing, apply the Canary Release label to this PR.

@github-actions github-actions Bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jun 24, 2026
@joshblack joshblack marked this pull request as ready for review June 24, 2026 23:11
@joshblack joshblack requested a review from a team as a code owner June 24, 2026 23:11
@joshblack joshblack requested review from Copilot and lesliecdubs June 24, 2026 23:11

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR expands the set of @primer/react components that are eligible for React Compiler by removing them from the opt-out (“unsupported”) list, and adds a patch changeset to communicate the performance improvement in the next release.

Changes:

  • Removed Autocomplete, Banner, Button, ConfirmationDialog, Dialog, PageLayout, Pagination, UnderlineNav, and experimental SelectPanel2 from the React Compiler unsupported patterns list.
  • Added a patch changeset describing the rendering performance improvement from React Compiler enablement.
Show a summary per file
File Description
packages/react/script/react-compiler.mjs Updates the unsupported glob list so additional components are included in React Compiler transforms.
.changeset/react-compiler-components.md Adds a patch changeset documenting the performance improvement for the newly-enabled components.

Copilot's findings

  • Files reviewed: 2/2 changed files
  • Comments generated: 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants