Underline nav shared observer coalesced rebuild#8035
Draft
mattcosta7 wants to merge 3 commits into
Draft
Conversation
…registry Reworks `createDescendantRegistry` to support an optional shared IntersectionObserver owned by the Provider (instead of one observer per item) and to coalesce registry rebuilds so multiple registrations in the same tick trigger a single rebuild. Both UnderlineNav and ActionBar opt into these via the new `useRegisterOverflowObserver` hook.
- ActionBar opts into the shared IntersectionObserver via `useRegisterOverflowObserver` (threshold 0.75), with grouped items using the `disabled` option to skip subscription, matching the previous early-return behavior. - Add unit tests asserting coalesced rebuilds (N same-tick registrations -> single rebuild) and shared-observer fan-out (one observer, one callback updating all items), plus observer unobserve/disconnect cleanup.
🦋 Changeset detectedLatest commit: 13d8541 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
… of offsetTop reads (#8030) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: mattcosta7 <8616962+mattcosta7@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
Changelog
New
Changed
Removed
Rollout strategy
Testing & Reviewing
Merge checklist