feat: support prefix/route when managed backend is behind a corporate…#134
Open
jeroenflvr wants to merge 1 commit intoprestodb:masterfrom
Open
feat: support prefix/route when managed backend is behind a corporate…#134jeroenflvr wants to merge 1 commit intoprestodb:masterfrom
jeroenflvr wants to merge 1 commit intoprestodb:masterfrom
Conversation
|
Can you add some intergration/unit test for the same? |
swapsmagic
reviewed
Dec 20, 2023
Comment on lines
+347
to
+352
| pattern = r"(http[s]?://[^/]+)(/.*)" | ||
| try: | ||
| return re.sub(pattern, r"\1" + self._prefix + r"\2", self._next_uri) | ||
| except TypeError: | ||
| logger.error("Unable to update url with prefix. " | ||
| "Continuing without prefix.") |
There was a problem hiding this comment.
Instead of failing during query execution, does it make sense to raise the error during the initialization if the _prefix provided doesn't match the regex?
swapsmagic
reviewed
Dec 20, 2023
swapsmagic
left a comment
swapsmagic
left a comment
There was a problem hiding this comment.
Adding some unit test/integration test will be useful.
Author
|
Valid point. Updating. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for a route/prefix when the presto backend is behind a corporate firewall on a route and presto is not managed by you.